-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust codecov settings #1830
Adjust codecov settings #1830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
+ Coverage 46.91% 48.54% +1.63%
==========================================
Files 165 169 +4
Lines 12950 13370 +420
==========================================
+ Hits 6075 6490 +415
- Misses 6875 6880 +5 ☔ View full report in Codecov by Sentry. |
I still see the error in the PR 🤔. Does the fix only apply when it's merged? |
Making some more adjustments, it should be gone when the checks pass |
Working as expected 🎉 But I think to be 100% sure we need to create a PR with lines of code changed and not tested 😆 Thanks! I think we can merge this now 👍🏻 |
* remove pr annotations * disable failing CI
Description
Fixes https://kflabs.slack.com/archives/C04GNE3JP6Z/p1712311488621489